-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify DictManager's get_tracker() method #122
base: master
Are you sure you want to change the base?
Modify DictManager's get_tracker() method #122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @entropidelic)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @entropidelic)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @entropidelic)
src/starkware/cairo/common/dict.py
line 60 at r1 (raw file):
Gets a dict tracker given the dict_ptr. """ if isinstance(dict_ptr, VmConstsReference):
Can't you just add your object type here?
Code quote:
if isinstance(dict_ptr, VmConstsReference):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @entropidelic)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @entropidelic)
src/starkware/cairo/common/dict.py
line 60 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
Can't you just add your object type here?
Actually, just test that the dict_ptr is not a RelocatableValue.
Suggestion:
if not isinstance(dict_ptr, RelocatableValue):
dict_ptr = dict_ptr.address_
This change will greately simplify our integration with the
cairo-rs
VM, since our API can't return objects of the typeVmConstsReference
.This change is