Skip to content

Commit

Permalink
Fix String Comparison and Improve Git Diff Command in Script (#7329)
Browse files Browse the repository at this point in the history
Co-authored-by: orizi <[email protected]>
  • Loading branch information
SITADRITA1 and orizi authored Feb 28, 2025
1 parent c539d07 commit a33757e
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion docs/SECURITY.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ If there are any vulnerabilities in **Cairo**, don't hesitate to _report them_.

3. We will evaluate the vulnerability and, if necessary, release a fix or mitigating steps to address it. We will contact you to let you know the outcome, and will credit you in the report.

Please **do not disclose the vulnerability publicly** until a fix is released!
Please **do not disclose the vulnerability publicly** until a fix has been released!

4. Once we have either a) published a fix, or b) declined to address the vulnerability for whatever reason, you are free to publicly disclose it.
2 changes: 1 addition & 1 deletion scripts/release_crates.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# An optional argument, '-s | --skip-first <#num_to_skip>', can be passed to skip the first #num_to_skip crates, otherwise SKIP_FIRST is set to 0.
if [ "$1" == "-s" ] || [ "$1" == "--skip-first" ]; then
if [ "$1" = "-s" ] || [ "$1" = "--skip-first" ]; then
if [ -z "$2" ]; then
echo "Error: --skip-first requires a numeric argument."
exit 1
Expand Down
2 changes: 1 addition & 1 deletion scripts/sierra_update_check.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ HEAD_BRANCH=$2

# Assuming all updates are provided as inputs - finding if they are in any of the relevant crates.
MERGE_BASE=$(git merge-base $BASE_BRANCH $HEAD_BRANCH)
git diff --name-only $MERGE_BASE..$HEAD_BRANCH | grep \
git diff --name-only "$MERGE_BASE".."$HEAD_BRANCH" | grep -q -E
-e 'crate/cairo-lang-sierra/' \
-e 'crate/cairo-lang-sierra-gas/' \
-e 'crate/cairo-lang-sierra-ap-change/' \
Expand Down

0 comments on commit a33757e

Please sign in to comment.