-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error ptr for closure return type. #6795
Conversation
d5a2c11
to
79abce2
Compare
2226bd5
to
e65dc5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @Tomer-StarkWare)
crates/cairo-lang-semantic/src/expr/test_data/function_call
line 293 at r1 (raw file):
--> lib.cairo:2:11 || -> u8 { ^^
what was the error before?
add another reply here with the diff.
(if you revert the rust changes and add the test - what would have been the result)
Code quote:
error: Unexpected return type. Expected: "core::integer::u8", found: "core::integer::u16".
--> lib.cairo:2:11
|| -> u8 {
^^
e65dc5f
to
67f76fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @orizi)
crates/cairo-lang-semantic/src/expr/test_data/function_call
line 293 at r1 (raw file):
Previously, orizi wrote…
what was the error before?
add another reply here with the diff.
(if you revert the rust changes and add the test - what would have been the result)
This is the error without the changes:
Code snippet:
error: Unexpected return type. Expected: "core::integer::u8", found: "core::integer::u16".
--> lib.cairo:2:14
|| -> u8 {
^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)
79abce2
to
b3f7c3b
Compare
67f76fd
to
e9ccf6e
Compare
No description provided.