Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error ptr for closure return type. #6795

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

Tomer-StarkWare
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @Tomer-StarkWare)


crates/cairo-lang-semantic/src/expr/test_data/function_call line 293 at r1 (raw file):

 --> lib.cairo:2:11
    || -> u8 {
          ^^

what was the error before?
add another reply here with the diff.
(if you revert the rust changes and add the test - what would have been the result)

Code quote:

error: Unexpected return type. Expected: "core::integer::u8", found: "core::integer::u16".
 --> lib.cairo:2:11
    || -> u8 {
          ^^

Copy link
Collaborator Author

@Tomer-StarkWare Tomer-StarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @orizi)


crates/cairo-lang-semantic/src/expr/test_data/function_call line 293 at r1 (raw file):

Previously, orizi wrote…

what was the error before?
add another reply here with the diff.
(if you revert the rust changes and add the test - what would have been the result)

This is the error without the changes:

Code snippet:

error: Unexpected return type. Expected: "core::integer::u8", found: "core::integer::u16".
 --> lib.cairo:2:14
    || -> u8 {
             ^

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)

@Tomer-StarkWare Tomer-StarkWare changed the base branch from tomerc/return-error-ptr to main December 3, 2024 07:30
@Tomer-StarkWare Tomer-StarkWare added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit e669a7b Dec 3, 2024
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants