Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making sure sierra-debug-type names are not duplicated on long types. #6796

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Dec 2, 2024

Fixes issue #6607.

@reviewable-StarkWare
Copy link

This change is Reviewable

@orizi orizi force-pushed the orizi/remove-duplicated-sierra-names branch from 00bea3d to 87ba4a0 Compare December 2, 2024 11:57
@ilyalesokhin-starkware
Copy link
Contributor

crates/cairo-lang-sierra-generator/src/replace_ids.rs line 115 at r1 (raw file):

                // the full type name.
                if value.contains("...") {
                    value += &id.id.to_string();

what is happening here?

are you adding the id in addition to the the ...?

Code quote:

value += &id.id.to_string();

Copy link
Contributor

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 8 files at r1, all commit messages.
Reviewable status: 7 of 8 files reviewed, 1 unresolved discussion (waiting on @orizi)

Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 7 of 8 files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)


crates/cairo-lang-sierra-generator/src/replace_ids.rs line 115 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

what is happening here?

are you adding the id in addition to the the ...?

The previous attempt, ignore - will revert this.

@orizi orizi force-pushed the orizi/remove-duplicated-sierra-names branch from 87ba4a0 to 28ab9bb Compare December 3, 2024 13:31
Copy link
Contributor

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit 4af513e Dec 3, 2024
48 checks passed
@orizi orizi deleted the orizi/remove-duplicated-sierra-names branch December 10, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Cannot compile contracts: Invalid order of type declarations for serialization.
3 participants