Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the concrete trait from generated closure function key. #7112

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented Jan 18, 2025

Fixed #7095

@orizi orizi requested a review from TomerStarkware January 18, 2025 18:38
@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@TomerStarkware TomerStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)


crates/cairo-lang-lowering/src/lower/generated_test.rs line 40 at r1 (raw file):

    )
    .split();
    println!("test_function:\n{}", semantic_diagnostics);

is this suppose to be here?

Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TomerStarkware)


crates/cairo-lang-lowering/src/lower/generated_test.rs line 40 at r1 (raw file):

Previously, TomerStarkware wrote…

is this suppose to be here?

Done.

@orizi orizi force-pushed the orizi/fix-closure-function-rewrites branch from a14573b to e28ef5f Compare January 18, 2025 21:25
Copy link
Collaborator

@TomerStarkware TomerStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi orizi added this pull request to the merge queue Jan 19, 2025
Merged via the queue into main with commit 9351827 Jan 19, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: compilation panic: cairo-lang-lowering IndexMap: key not found
3 participants