Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos and improve clarity #7373

Merged
merged 6 commits into from
Mar 2, 2025
Merged

Conversation

Alex-Roleks
Copy link
Contributor

This PR corrects several typos and improves clarity in documentation across multiple files in the cairo-lang-lowering crate. Key fixes include:

  • Correcting spelling mistakes such as rather thenrather than and allowallows.
  • Improving phrasing for better readability we need the make surewe need to ensure.
  • Deleted extra space in comment section.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 4 files at r1, all commit messages.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion


crates/cairo-lang-lowering/src/lower/refs.rs line 14 at r1 (raw file):

use crate::db::LoweringGroup;

// Information about members captured by the closure and their types.

Suggestion:

/// Information about members captured by the closure and their types.

@Alex-Roleks
Copy link
Contributor Author

Updated file refs.rs according to your suggestion.

@orizi orizi enabled auto-merge March 2, 2025 23:10
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Alex-Roleks)

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Alex-Roleks)

@orizi orizi added this pull request to the merge queue Mar 2, 2025
Merged via the queue into starkware-libs:main with commit 7ed6d32 Mar 2, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants