Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add stateless validator #21

Closed

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Apr 4, 2024

This change is Reviewable

@ArniStarkware
Copy link
Contributor Author

crates/gateway/src/transaction_validator.rs line 15 at r1 (raw file):

// TODO(Arni, 1/5/2024): Remove the this value if we use a type which supports version 3 and above
// only.
// It is an assumption of this repository that the minimal supported transaction version is 3.

Delete.

Code quote:

// TODO(Arni, 1/5/2024): Remove the this value if we use a type which supports version 3 and above
// only.
// It is an assumption of this repository that the minimal supported transaction version is 3.

Copy link
Contributor Author

@ArniStarkware ArniStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 6 files reviewed, 2 unresolved discussions (waiting on @dafnamatsry)


crates/gateway/src/errors.rs line 33 at r1 (raw file):

    BlockedTransactionVersion(TransactionVersion, String),
    #[error("This transaction type is not supported by the mempool")]
    TransactionTypeNotSupported,

Remove.

Code quote:

    #[error("Transactions of version {0:?} are not valid. {1}")]
    InvalidTransactionVersion(TransactionVersion, String),
    #[error("Blocked transaction version {0:?}. {1}")]
    BlockedTransactionVersion(TransactionVersion, String),
    #[error("This transaction type is not supported by the mempool")]
    TransactionTypeNotSupported,

@ArniStarkware
Copy link
Contributor Author

Will be replaced with a tower.

@ArniStarkware ArniStarkware deleted the arni/transaction_validator/stateless/worktree branch April 10, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant