Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: wrap cairo lang version id for code dedup #469

Closed
wants to merge 1 commit into from

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Jul 14, 2024

This change is Reviewable

Copy link
Contributor Author

ArniStarkware commented Jul 14, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ArniStarkware and the rest of your teammates on Graphite Graphite

@ArniStarkware ArniStarkware mentioned this pull request Jul 14, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 27.08333% with 70 lines in your changes missing coverage. Please review.

Project coverage is 80.61%. Comparing base (b1804bb) to head (6d3621b).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/gateway/src/compiler_version.rs 24.17% 69 Missing ⚠️
crates/gateway/src/config.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
- Coverage   83.38%   80.61%   -2.78%     
==========================================
  Files          37       37              
  Lines        1770     1847      +77     
  Branches     1770     1847      +77     
==========================================
+ Hits         1476     1489      +13     
- Misses        215      279      +64     
  Partials       79       79              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArniStarkware
Copy link
Contributor Author

Restacked on an alternative path.

@ArniStarkware ArniStarkware deleted the arni/chore/code_dedup/version_id_wrapper branch July 22, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants