Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: sort and rename component clients into dedicated dirs #521

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

uriel-starkware
Copy link
Contributor

@uriel-starkware uriel-starkware commented Jul 23, 2024

This change is Reviewable

@uriel-starkware uriel-starkware force-pushed the uriel/sort-component-client-code branch from 08a9987 to ddd6017 Compare July 23, 2024 11:21
@uriel-starkware uriel-starkware force-pushed the uriel/sort-component-client-code branch from ddd6017 to 2493967 Compare July 23, 2024 11:22
Copy link
Contributor Author

@uriel-starkware uriel-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 7 files at r1, 7 of 7 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @uriel-starkware)

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 90.56604% with 5 lines in your changes missing coverage. Please review.

Project coverage is 83.59%. Comparing base (d09a690) to head (2493967).

Files Patch % Lines
...ra/src/component_client/remote_component_client.rs 89.74% 1 Missing and 3 partials ⚠️
...fra/src/component_client/local_component_client.rs 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #521   +/-   ##
=======================================
  Coverage   83.59%   83.59%           
=======================================
  Files          37       39    +2     
  Lines        1780     1780           
  Branches     1780     1780           
=======================================
  Hits         1488     1488           
  Misses        215      215           
  Partials       77       77           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lev-starkware lev-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 7 files at r1, 7 of 7 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @uriel-starkware)

@uriel-starkware uriel-starkware merged commit f50696c into main Jul 23, 2024
8 checks passed
@uriel-starkware uriel-starkware deleted the uriel/sort-component-client-code branch July 23, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants