perf(storage)!: not save event_offset in the events table

[DvirYo-starkware]

This change is 

[codecov]

Codecov Report

Attention: Patch coverage is 82.25806% with 11 lines in your changes missing coverage. Please review.

Project coverage is 69.02%. Comparing base (afef1e6) to head (f164dbf).

Files	Patch %	Lines
crates/papyrus_storage/src/body/events.rs	83.01%	2 Missing and 7 partials ⚠️
crates/papyrus_storage/src/body/mod.rs	77.77%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2062   +/-   ##
=======================================
  Coverage   69.01%   69.02%           
=======================================
  Files         130      130           
  Lines       17426    17447   +21     
  Branches    17426    17447   +21     
=======================================
+ Hits        12026    12042   +16     
- Misses       4068     4069    +1     
- Partials     1332     1336    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dan-starkware]

Reviewed 2 of 5 files at r1, all commit messages.
Reviewable status: 2 of 5 files reviewed, 4 unresolved discussions (waiting on @DvirYo-starkware and @ShahakShama)

a discussion (no related file):
Please check and add TODO in case we don't really need the capability of iterating by more than one contract.

---

---

crates/papyrus_storage/src/body/events.rs line 144 at r2 (raw file):

    txn: &'txn DbTransaction<'env, RO>,
    file_handles: &'txn FileHandlers<RO>,
    // This value is the next event to return. If it is None there are no more events.

Please rephrase better
Also, rename to something along next_entry_in_event_table

Code quote:

// This value is the next event to return. If it is None there are no more events.

---

crates/papyrus_storage/src/body/events.rs line 151 at r2 (raw file):

    cursor: EventsTableCursor<'txn>,
    transaction_metadata_table: TransactionMetadataTable<'env>,
    current_event_index: usize,

This is the offset in the transaction output, right?

Code quote:

current_event_index

---

crates/papyrus_storage/src/body/events.rs line 321 at r2 (raw file):

            transaction_metadata_table,
            current_event_index: key.1.1.0,
            current_contract_address: key.0,

Should be taken from current?

Code quote:

current_contract_address: key.0,

[DvirYo-starkware]

Reviewable status: 2 of 5 files reviewed, 3 unresolved discussions (waiting on @ShahakShama)

---

crates/papyrus_storage/src/body/events_test.rs line 22 at r1 (raw file):

    let from_addresses =
        vec![ContractAddress(patricia_key!("0x22")), ContractAddress(patricia_key!("0x23"))];
    let block = get_test_block(4, Some(5), Some(from_addresses), None);

added more blocks for the test for more coverage

---

crates/papyrus_storage/src/body/events_test.rs line 100 at r3 (raw file):

        EventIndexInTransactionOutput(2),
    );
    let txn = storage_reader.begin_ro_txn().unwrap();

fix the bug in the test also for the event iter by index test

[dan-starkware]

Reviewed 5 of 5 files at r6, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ShahakShama)