feat(network): add wrapper for Option<SignedBlockHeader> and add converters to/from Vec<u8> #2063
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2063 +/- ##
==========================================
- Coverage 69.73% 69.66% -0.08%
==========================================
Files 131 131
Lines 17196 17202 +6
Branches 17196 17202 +6
==========================================
- Hits 11992 11983 -9
- Misses 3880 3896 +16
+ Partials 1324 1323 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ShahakShama)
crates/papyrus_protobuf/src/sync.rs line 41 at r1 (raw file):
// We have this struct in order to implement on it traits. #[derive(Debug, Clone, PartialEq, Eq)] pub struct BlockHeaderResponse(pub Option<SignedBlockHeader>);
use the same name as in the protobuf, or add TODO to rename it for consistency
ShahakShama
force-pushed
the
shahak/vec_u8_conv_header_response
branch
from
bdd85e8
to
cee22cb
Compare
There was a problem hiding this comment.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @asmaastarkware)
crates/papyrus_protobuf/src/sync.rs line 41 at r1 (raw file):
Previously, asmaastarkware (asmaa-starkware) wrote…
use the same name as in the protobuf, or add TODO to rename it for consistency
Done.
There was a problem hiding this comment.
Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @ShahakShama)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)
…erters to/from Vec<u8>
ShahakShama
dismissed stale reviews from DvirYo-starkware and asmaastarkware
via
8d44a14
ShahakShama
force-pushed
the
shahak/vec_u8_conv_header_response
branch
from
cee22cb
to
8d44a14
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:
This change is