feat(consensus): add an error type for consensus and utlize in SingleHeightConsensus

[matan-starkware]

This change is 

[matan-starkware]

• refactor(consensus): the SHC goes from a task to an object which is called directly #2079
• feat(consensus): set NodeId to ContractAddress #2078
• feat(consensus): update the protobuf with ConsensusMessage which will wrap all consensus messages #2077
• feat(consensus): change the channel type for Peering to SingleHeightConsensus messages #2069
• feat(consensus): add an error type for consensus and utlize in SingleHeightConsensus #2064 👈
• feat(consensus): add validator flow to SingleHeightConsensus #2059
• feat(consensus): create SingleHeightConsensus struct #2058
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @matan-starkware and the rest of your teammates on Graphite

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.73%. Comparing base (6fb8430) to head (7acc57e).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2064      +/-   ##
==========================================
+ Coverage   68.68%   68.73%   +0.04%     
==========================================
  Files         131      131              
  Lines       17486    17486              
  Branches    17486    17486              
==========================================
+ Hits        12011    12019       +8     
+ Misses       4143     4133      -10     
- Partials     1332     1334       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DvirYo-starkware]

Reviewed 3 of 4 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: 4 of 5 files reviewed, 3 unresolved discussions (waiting on @matan-starkware)

a discussion (no related file):
Try to make the comment more concise. To see ten lines of documentation for each line of code is annoying, time-consuming when reading the code, and has overhead for maintenance.

---

---

crates/sequencing/papyrus_consensus/Cargo.toml line 14 at r3 (raw file):

starknet_api.workspace = true
tokio = { workspace = true, features = ["full"] }
thiserror.workspace = true

We try to order the dependencies alphabetically

Code quote:

tokio = { workspace = true, features = ["full"] }
thiserror.workspace = true

---

crates/sequencing/papyrus_consensus/src/single_height_consensus.rs line 65 at r3 (raw file):

        // This means that Context failed when building a proposal. While Tendermint is able to
        // handle invalid proposals, I think it's more straightforward to panic here. If needed, we
        // can change this to work like an invalid proposal.

Consider deleting this entire comment as an example of where you can be more concise in comments.

Code quote:

        // This means that Context failed when building a proposal. While Tendermint is able to
        // handle invalid proposals, I think it's more straightforward to panic here. If needed, we
        // can change this to work like an invalid proposal.

[matan-starkware]

Reviewable status: 4 of 5 files reviewed, 3 unresolved discussions (waiting on @DvirYo-starkware)

a discussion (no related file):

Previously, DvirYo-starkware wrote…

Try to make the comment more concise. To see ten lines of documentation for each line of code is annoying, time-consuming when reading the code, and has overhead for maintenance.

Done.

---

---

crates/sequencing/papyrus_consensus/Cargo.toml line 14 at r3 (raw file):

Previously, DvirYo-starkware wrote…

We try to order the dependencies alphabetically

oh I had assumed VScode would do that automatically.

---

crates/sequencing/papyrus_consensus/src/single_height_consensus.rs line 65 at r3 (raw file):

Previously, DvirYo-starkware wrote…

Consider deleting this entire comment as an example of where you can be more concise in comments.

Done.

[DvirYo-starkware]

Reviewed 3 of 3 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)