Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(protobuf): add auto impl for statediffchunk #2115

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

eitanm-starkware
Copy link
Contributor

@eitanm-starkware eitanm-starkware commented Jun 17, 2024

This change is Reviewable

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.39%. Comparing base (b9c9593) to head (b0f2ac3).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/papyrus_protobuf/src/sync.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2115      +/-   ##
==========================================
- Coverage   68.41%   68.39%   -0.03%     
==========================================
  Files         132      132              
  Lines       17602    17597       -5     
  Branches    17602    17597       -5     
==========================================
- Hits        12042    12035       -7     
- Misses       4226     4229       +3     
+ Partials     1334     1333       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ShahakShama
ShahakShama previously approved these changes Jun 17, 2024
Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @eitanm-starkware)


crates/papyrus_protobuf/src/sync.rs line 80 at r1 (raw file):

    DeclaredClass(DeclaredClass),
    DeprecatedDeclaredClass(DeprecatedDeclaredClass),
}

newline between each block

ShahakShama
ShahakShama previously approved these changes Jun 17, 2024
Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @eitanm-starkware)

@eitanm-starkware eitanm-starkware added this pull request to the merge queue Jun 17, 2024
@eitanm-starkware eitanm-starkware removed this pull request from the merge queue due to a manual request Jun 17, 2024
Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @eitanm-starkware)

@eitanm-starkware eitanm-starkware added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit 7f309d7 Jun 17, 2024
34 checks passed
@eitanm-starkware eitanm-starkware deleted the eitan/protobuf__auto_impl_for_statediffchunk branch June 17, 2024 13:04
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants