chore(sync): rename stream factory to builder #2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2119 +/- ##
==========================================
- Coverage 65.50% 65.44% -0.07%
==========================================
Files 136 136
Lines 18106 18106
Branches 18106 18106
==========================================
- Hits 11861 11850 -11
- Misses 4957 4967 +10
- Partials 1288 1289 +1 ☔ View full report in Codecov by Sentry. |
ShahakShama
previously approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @eitanm-starkware)
eitanm-starkware
force-pushed
the
eitan/rename_stream_factory_to_builder
branch
from
fcfb63b
to
e21e216
Compare
eitanm-starkware
force-pushed
the
eitan/rename_stream_factory_to_builder
branch
from
e21e216
to
18bda30
Compare
ShahakShama
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Reviewed 8 of 8 files at r2, all commit messages.
Reviewable status:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is