refactor(network): db executor communicates through channels

[ShahakShama]

• refactor(network): remove Data from db executor
• refactor(network): db executor communicates through channels

---

This change is 

[codecov]

Codecov Report

Attention: Patch coverage is 40.00000% with 84 lines in your changes missing coverage. Please review.

Project coverage is 64.37%. Comparing base (15cbec4) to head (bb9be89).

❗ Current head bb9be89 differs from pull request most recent head f69f005

Please upload reports for the commit f69f005 to get more accurate results.

Files	Patch %	Lines
crates/papyrus_network/src/network_manager/mod.rs	0.00%	66 Missing ⚠️
crates/papyrus_network/src/db_executor/mod.rs	75.67%	12 Missing and 6 partials ⚠️

Additional details and impacted files

@@                  Coverage Diff                   @@
##           shahak/remove_data    #2121      +/-   ##
======================================================
- Coverage               64.39%   64.37%   -0.03%     
======================================================
  Files                     136      136              
  Lines                   17870    17941      +71     
  Branches                17870    17941      +71     
======================================================
+ Hits                    11508    11550      +42     
- Misses                   5083     5113      +30     
+ Partials                 1279     1278       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eitanm-starkware]

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)

[asmaastarkware]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)

[matan-starkware]

Reviewed 2 of 4 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @ShahakShama)

---

crates/papyrus_network/src/db_executor/mod.rs line 88 at r2 (raw file):

    state_diff_queries_receiver:
        Option<SqmrQueryReceiver<StateDiffQuery, DataOrFin<StateDiffChunk>>>,
}

The DBExecutor is going to become the SyncServer. And therefore it make sense to have specific reference to header and state diff. right?

Code quote:

pub struct DBExecutor {
    storage_reader: StorageReader,
    // TODO(shahak): Make this non-option.
    header_queries_receiver: Option<SqmrQueryReceiver<HeaderQuery, DataOrFin<SignedBlockHeader>>>,
    // TODO(shahak): Make this non-option.
    state_diff_queries_receiver:
        Option<SqmrQueryReceiver<StateDiffQuery, DataOrFin<StateDiffChunk>>>,
}

---

crates/papyrus_network/src/db_executor/mod.rs line 123 at r2 (raw file):

            tokio::select! {
                Some((query_result, response_sender)) = header_queries_receiver_future => {

What happens if the future returns None?

Code quote:

                Some((query_result, response_sender)) = header_queries_receiver_future => {

---

crates/papyrus_network/src/db_executor/mod.rs line 264 at r2 (raw file):

    // If this function fails, we still want to send fin before failing.
    let result = send_data_without_fin_for_query(&storage_reader, query, &mut sender).await;
    sender.feed(DataOrFin(None)).await?;

when do we flush?

Code quote:

sender.feed(DataOrFin(None)).await?;

---

crates/papyrus_network/src/db_executor/mod.rs line 295 at r2 (raw file):

        for data in data_vec {
            // TODO: consider implement retry mechanism.
            sender.feed(DataOrFin(Some(data))).await?;

When do we flush?

Code quote:

sender.feed(DataOrFin(Some(data))).await?;

[ShahakShama]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @matan-starkware)

---

crates/papyrus_network/src/db_executor/mod.rs line 88 at r2 (raw file):

Previously, matan-starkware wrote…

The DBExecutor is going to become the SyncServer. And therefore it make sense to have specific reference to header and state diff. right?

Yes, we will move it from the network crate

---

crates/papyrus_network/src/db_executor/mod.rs line 123 at r2 (raw file):

Previously, matan-starkware wrote…

What happens if the future returns None?

Fixed. If you're interested I can tell you what was the previous code in huddle

---

crates/papyrus_network/src/db_executor/mod.rs line 264 at r2 (raw file):

Previously, matan-starkware wrote…

when do we flush?

We don't need to, it's flushed automatically (not sure when but I've checked the final PR with e2e with the node executable so it works)

---

crates/papyrus_network/src/db_executor/mod.rs line 295 at r2 (raw file):

Previously, matan-starkware wrote…

When do we flush?

Same

[matan-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)

---

crates/papyrus_network/src/db_executor/mod.rs line 123 at r2 (raw file):

Previously, ShahakShama wrote…

Fixed. If you're interested I can tell you what was the previous code in huddle

I don't see any change in the code.

[ShahakShama]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)

---

crates/papyrus_network/src/db_executor/mod.rs line 123 at r2 (raw file):

Previously, matan-starkware wrote…

I don't see any change in the code.

Forgot to push 😅

[matan-starkware]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)

---

crates/papyrus_network/src/db_executor/mod.rs line 123 at r2 (raw file):

Previously, ShahakShama wrote…

Forgot to push 😅

Ok. Do we prefer expect outside of test code?

[ShahakShama]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)

---

crates/papyrus_network/src/db_executor/mod.rs line 123 at r2 (raw file):

Previously, matan-starkware wrote…

Ok. Do we prefer expect outside of test code?

You and clippy are best friends

[matan-starkware]

Reviewed 3 of 3 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)

---

crates/papyrus_network/src/db_executor/mod.rs line 123 at r2 (raw file):

Previously, ShahakShama wrote…

You and clippy are best friends

:D