Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tx and event commitments #150

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add tx and event commitments #150

wants to merge 1 commit into from

Conversation

dan-starkware
Copy link
Collaborator

@dan-starkware dan-starkware commented Nov 9, 2023 •
edited by alon-dotan-starkware
Loading

This change is Reviewable

@dan-starkware dan-starkware requested review from giladchase and removed request for giladchase November 9, 2023 07:27
giladchase
giladchase requested changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware)

Cargo.toml line 3 at r1 (raw file):

[package]
name = "starknet_api"
version = "0.6.0-rc2"

Suggestion:

version = "0.6.0-rc3"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giladchase giladchase giladchase requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-starkware @giladchase