feat: calculate block hash

[yoavGrs]

This change is 

[ShahakShama]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yoavGrs)

---

src/block_hash/block_hash_calculator.rs line 46 at r1 (raw file):

///     data_gas_price_wei, data_gas_price_fri, starknet_version, 0, parent_block_hash
/// ).
pub fn calculate_block_hash(block_hash_input: &BlockHashInput<'_, '_, '_, '_>) -> BlockHash {

Why not receive Block?

[yoavGrs]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ShahakShama)

---

src/block_hash/block_hash_calculator.rs line 46 at r1 (raw file):

Previously, ShahakShama wrote…

Why not receive Block?

Because Block contains block_hash and optional commitments.
Should I define a new struct, BlockWithoutHash?

[dorimedini-starkware]

Reviewed 7 of 7 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ShahakShama)

[ShahakShama]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yoavGrs)

---

src/block_hash/block_hash_calculator.rs line 46 at r1 (raw file):

Previously, yoavGrs wrote…

Because Block contains block_hash and optional commitments.
Should I define a new struct, BlockWithoutHash?

Yes, I'd rename the current Block to BlockWithCommitments. You can put a TODO for now

[yoavGrs]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ShahakShama)

---

src/block_hash/block_hash_calculator.rs line 46 at r1 (raw file):

Previously, ShahakShama wrote…

Yes, I'd rename the current Block to BlockWithCommitments. You can put a TODO for now

The structure of Block should change and contain: BlockHeader (currently BlockHeaderWithoutHash), BlockBody, BlockHeaderCommitments and BlockHash.
It's a breaking change that is bigger than a renaming TODO.

[ShahakShama]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)

[dorimedini-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)

[dorimedini-starkware]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)