Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creating from non-stashbox sources in Scene Tagger #4001

Merged
merged 3 commits into from
Aug 7, 2023

Conversation

DingDongSoLong4
Copy link
Collaborator

This fixes two bugs in #3912 that came up in Discord related to using non-stashbox scrapers in the Scene Tagger:

  • When you create a new performer, the created performer replaces all performers that were previously about to be associated with a scene.
  • And creating a studio does not work at all.

I also found a different bug while trying to reproduce the above issues, where the "Create Studio" dialog still shows the (blank) scraped image and its checkbox even if the scraper doesn't return an image. The simple fix is just to not render the image if the path is missing.

@WithoutPants WithoutPants added the bug Something isn't working label Aug 7, 2023
@WithoutPants WithoutPants added this to the Version 0.22.0 milestone Aug 7, 2023
@WithoutPants WithoutPants merged commit a9d3188 into stashapp:develop Aug 7, 2023
@DingDongSoLong4 DingDongSoLong4 deleted the fix-tagger-create branch August 8, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants