Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace queue tab with discover tab which include other related content #4733

Open
wants to merge 28 commits into
base: develop
Choose a base branch
from

Conversation

cj12312021
Copy link
Collaborator

The pull request improves the queue tab (now named discover), which will allow users to view other scenes from the studio or performers within the player page. This work also added support for video previews when hovering over scenes within the tab. I uploaded a video of this work here https://discordapp.com/channels/559159668438728723/644934273459290145/1223103538893164708.

@cj12312021 cj12312021 added the feature Pull requests that add a new feature label Mar 29, 2024
@ghfsa
Copy link

ghfsa commented Mar 29, 2024

Can this be put below the player? Then we can have more real estate & hence larger thumbnails & more related content in grid view?
Horizontally placed buttons/tabs like 'Same Studio', 'Same Performer' etc placed just above that grid for filtering would be awesome

@cj12312021
Copy link
Collaborator Author

cj12312021 commented Mar 29, 2024

This pull request isn’t meant to do any significant restructuring of the player page. That task will happen in #4699 so that feedback will be better served there. But I will say that moving this tab below the video container will interfere with the advantage we have of being able to browse these options while keeping the video on screen, which imo would not be worth it. Browsing on this page is meant to be a secondary task and shouldn't get in the way of the primary task of viewing the video.

@cj12312021
Copy link
Collaborator Author

I can update the queue thumbnails to take up 40% of the available horizontal width. That should help improve the thumbnail size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull requests that add a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants