Group details: Flippable images in expanded view. #5367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been on my mind to revisit the movie/group image section of the details page since I completed this work a while back. At the time I recall a user had suggested a solution to toggle between the front and back covers rather than displaying both. I've implemented such a solution here when the details are expanded. In this view, we would ideally want to enlarge the images; the main issue was that doing so would take up too much horizontal space since two images were present. That is no longer the case with this solution. Given the amount of free real estate in the compact view, I still see the value in showing both images.
The video demo can be viewed here: https://discordapp.com/channels/559159668438728723/644934273459290145/1294513740279971862