Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize graph, rename old def to finite graph #44

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

clayrat
Copy link
Member

@clayrat clayrat commented Aug 29, 2019

No description provided.

Copy link
Contributor

@marcosh marcosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. @clayrat do you think it makes sense to keep the Finite variant? Maybe we could make it just a special case of the most general one

@clayrat
Copy link
Member Author

clayrat commented Aug 30, 2019

Yeah, I could spend a bit more time to special-case it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants