Support 'oxford comma' format and non-string types in listing #690
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #693
This PR:
listing
. Depending on location etc., some people list items using an oxford comma. For example:Prints out
The default is
oxford=False
to avoid changing the default behavior.str
inlisting
. The code for this function almost entirely already allowed this, this PR mostly changes type annotations and adds a couple ofstr()
calls to fully support it. This allows for things like:Which may print:
items
. Python defineslist
type as invariant; we should useSequence
instead as that is covariant. That is: