Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some functions are dynamically typed #40

Open
hadrienk opened this issue Oct 30, 2017 · 3 comments
Open

Some functions are dynamically typed #40

hadrienk opened this issue Oct 30, 2017 · 3 comments
Assignees
Labels

Comments

@hadrienk
Copy link

hadrienk commented Oct 30, 2017

Some functions are supposed to return different types depending on the types of the parameters.
We deal with this adjusting the expression type in the expression visitor (see + - * / operators) or in the native function visitor (see nvl) but other cases are not yet handled; abs, log, power and trunc.

The fact that we need to make this gymnastic should be enough to refactor the function abstraction as extending the expression interfaces.

@hadrienk hadrienk self-assigned this Oct 30, 2017
@hadrienk
Copy link
Author

@eivindgi, @pawbu, @takvamborgen do you want to take a look at this?

@hadrienk
Copy link
Author

@hadrienk hadrienk added the bug label Oct 30, 2017
@hadrienk
Copy link
Author

Actually, we should match functions with the names and the arguments' types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant