Exception handling PoC #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawbu
requested changes
Nov 15, 2017
| }; | ||
| lexer.addErrorListener(errorListener); | ||
| parser.addErrorListener(errorListener); | ||
| public VTLParser.StartContext compile(Reader reader, Consumer<VTLScriptException> errorConsumer) throws IOException { |
There was a problem hiding this comment.
I'm not sure about the compile word here. In antlr it is used in the context of compiling a grammar file.
There was a problem hiding this comment.
maybe getRootContext or getStartContext. Or maybe split this method as it sets up lexer and parser and also gets the start context.
| ), ctx | ||
| ); | ||
| } | ||
| // checkArgument( |
pawbu
approved these changes
Nov 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in preparation for #40. The goal is to improve the exception handling in the java-script project.
I created a new
ContextualRuntimeExceptionthat contains a reference to the ParserRuleContext we get from ANTLR so that we can give the position of an error to the user. I also addedVTLScriptExceptionwhich extends the ScriptException, mainly because the ScriptException constructors are too restricting.I adjusted
AssignmentVisitor,ExpressionVisitorandNativeFunctionsVisitorto use the new exceptions. Take a look atVTLErrorsTestfor an example of what the result is.