Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mode for gamma distribution is 0 for shape<=1 #212

Merged
merged 1 commit into from
May 27, 2024
Merged

fix: mode for gamma distribution is 0 for shape<=1 #212

merged 1 commit into from
May 27, 2024

Conversation

YeungOnion
Copy link
Contributor

addresses #210, opt for mode at singular point of x=0 in lieu of None.

@YeungOnion YeungOnion requested a review from henryjac April 8, 2024 21:41
@YeungOnion YeungOnion force-pushed the fix-mode-gamma branch 3 times, most recently from 2c8a36f to ecc39cc Compare April 15, 2024 02:38
@tessob
Copy link
Contributor

tessob commented Apr 16, 2024

Maybe it should be Option::None instead? As negative shape is not valid value to construct Gamma.

@YeungOnion
Copy link
Contributor Author

Yeah, now that you mention it, None for alpha<1.0 since it's singular and one sided makes more sense.

@YeungOnion YeungOnion closed this May 27, 2024
@YeungOnion YeungOnion reopened this May 27, 2024
@YeungOnion YeungOnion merged commit d1fd362 into master May 27, 2024
16 checks passed
@YeungOnion YeungOnion deleted the fix-mode-gamma branch May 27, 2024 03:08
@YeungOnion YeungOnion mentioned this pull request Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryjac henryjac Awaiting requested review from henryjac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YeungOnion @tessob