Make rustfmt happy
#219
Merged
Make rustfmt happy
#219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't expect this to break most other PR's, but if it does, should all be easy changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of this should be uncontroversial.
Rustfmt page (rules can be looked up here).
I've seen
fn_params_layout = "Compressed"in other projects, but all the code in statrs already adhered to the other rule ("Tall"), so I don't see why this should be"Compressed". Plus it only affects a few functions, so this wouldn't save many lines anyways.All the other rules that I removed seem unconventional to me, and again, all code in statrs at the moment adheres to these rules being
falseor not set. So I don't see a reason to keep these.