Remove feature = "nightly" gate where unneeded
#232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just saw this after I added my comment on the previous thread. This will be helpful! |
FreezyLemon
force-pushed
the
remove-unneeded-nightly-gate
branch
from
9ad2b3a to
ace9779
Compare
YeungOnion
approved these changes
May 26, 2024
|
Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nightlyfeature hides some testing helpers and macros, and all tests using any of them need to be hidden behind thenightlyfeature too.This isn't great (see #228) and I want to increase the amount of tests that can be run without unstable and/or nightly compiler features. The tests modified in this PR are low-hanging fruit, they don't require any nightly feature at all.