-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release 0.17.0 #235
release 0.17.0 #235
Conversation
Noting that at some point (#209) @FreezyLemon mentioned the idea of introducing MSRV to this project; I planned to delay adding that policy to the release that introduces that change that motivated it since this release is focused to get the project back on its feet. |
I got some advice that if we're going to introduce the msrv may as well not wait on it. I did some testing with I'll make these changes now. |
Any MSRV should really be checked in CI, since it's very easy to accidentally break it while updating dependencies. It would also be nice to document it somewhere, e.g. at the bottom of the README (including when and for what reasons it will be changed, and how the crate version will reflect MSRV changes) |
Seems like I only checked the lib in my local testing, our benches rely on I'm okay excluding those benchmarks from the package, but I've not found a way to split the dependencies for benchmarking apart from testing, unsure if this is possible. |
Another way of achieving this would be a crate feature that needs to be enabled for benchmarking, but it's not great for developer ergonomics. It's also possible to just disable the default features for criterion which should remove rayon and possibly reduces the MSRV. |
I can get it down to 1.65 with changing the features criterion uses and keeping the version pinned, which aligns around the 0.16 statrs release. However, my opposition is that the MSRV is higher than what the statrs lib itself needs, so I find it a little misguiding. I would clearly mention this in the docs. I don't like the option to gate benches with a feature, but given the below reasons, I think we could get by.
Thoughts? |
made a post on the forums to get others' input if this would be unexpected. |
I honestly thought that disabling the criterion default features would solve the problem. The benches feature doesn't feel great... I'd honestly just set the expectation that the MSRV is meant for crate users ( EDIT: The MSRV discussion has come to a point where it should probably be moved to its own thing. |
I agree, and it makes me wonder if it's better to
I'm leaning toward the last option, but it's potentially hiding a source of inconsistency in test results. |
doc: remove codecov badge before release to crates.io badge is pending its correctness, see PR #229 for progress
Holding off for this release doesn't seem like too big of a problem IMO. That would allow some time to discuss this in a separate issue etc. If you do want to include it for this release, I'd prefer option three as well. As I said above, |
Think I'll hold off on it. Since inclusion of it is only policy, I imagine it would only change the fix release version. |
I think this is okay for getting some more users back.
Open to feedback on the changelog, I used
release-plz
to generate the log for this release and made edits for further formatRemaining active work that is related to CI will be updated and likely minor version releases to [crates.io], included but not limited to: