-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update nalgebra requirement from 0.32 to 0.33 #249
Conversation
@dependabot rebase |
2421a49
to
5567ea3
Compare
Note: The |
@dependabot rebase |
5567ea3
to
45d64bf
Compare
After fixing the breaking change in nalgebra ( GAT is interesting and 1.65 was released ≈22 months ago, which also has some other language features. Our MSRV approach is certainly lenient enough, so I don't see a reason to not, does anyone else? |
45d64bf
to
1b825da
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #249 +/- ##
==========================================
- Coverage 93.73% 93.70% -0.04%
==========================================
Files 53 53
Lines 12010 11935 -75
==========================================
- Hits 11258 11184 -74
+ Misses 752 751 -1 ☔ View full report in Codecov by Sentry. |
1.65 sounds fine. I use the stats on lib.rs to get a rough picture of the ecosystem for things like this. The MSRV lockfile needs a bump. I mentioned it in #268, but it might need to be added to the
|
A newer version of nalgebra exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
doc(readme): add codecov badge doc(readme): rewording and change suggestions for contributors
1b825da
to
737125d
Compare
also derives Eq for DiscreteUniform distribution
2ac6ac6
to
cb55dca
Compare
Updates the requirements on nalgebra to permit the latest version.
Changelog
Sourced from nalgebra's changelog.
... (truncated)
Commits
You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)