-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some more inverse CDF functions #260
Conversation
Thanks for the contribution! For docs we've been writing the mathematical form for expression for inverse cdf's where possible, it more clearly distinguishes them from search implementations. I think what you've done in the beta distribution for tests is good. It's been mentioned before to use a "nice" way to test fwd and inverse cdf since a triple of EDIT: specified which distribution the inverse_cdf tests were already written for. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #260 +/- ##
==========================================
+ Coverage 89.49% 89.67% +0.18%
==========================================
Files 50 50
Lines 10851 10992 +141
==========================================
+ Hits 9711 9857 +146
+ Misses 1140 1135 -5 ☔ View full report in Codecov by Sentry. |
Thanks, I'll put together the documentation, and some tests that verify the forward and backward match to within reasonable precision. |
I wrote some tests and started on docstrings. I'll ping once I finish off the docstrings. |
@YeungOnion this is now ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me!
Thanks for fixing some of the other docs and catching the precision typo on the test. 10^+14 relative precision isn't any good.
I've been using
statrs
for a project I'm working on, and noticed that many distributions don't have an explicit implementation of the inverse cdf when they can be simply implemented.I wasn't sure what the expectations are for documentation and tests, I added some tests for a couple of them, but thought I should just ask if there is a standard I'm missing before writing a bunch of boilerplate.
If this contribution is welcome/desired, I'm happy to put in any docs/tests.