Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/multivariate dimension generic: electric boogaloo #262

Merged

Conversation

YeungOnion
Copy link
Contributor

working late and had the branch pointer with only the commit for Dirichlet distribution
this pr completes #253 for Multinomial as well as adding / updating tests for these two distributions.

@YeungOnion YeungOnion force-pushed the feat/multivariate-dimension-generic branch from a64464d to 2ae5e79 Compare August 16, 2024 06:01
@YeungOnion YeungOnion merged commit 5c2258c into statrs-dev:master Aug 16, 2024
6 checks passed
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 95.27897% with 11 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@a239ebe). Learn more about missing BASE report.
Report is 6 commits behind head on master.

Files Patch % Lines
src/distribution/multinomial.rs 95.00% 8 Missing ⚠️
src/distribution/internal.rs 89.65% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #262   +/-   ##
=========================================
  Coverage          ?   90.32%           
=========================================
  Files             ?       49           
  Lines             ?    11242           
  Branches          ?        0           
=========================================
  Hits              ?    10154           
  Misses            ?     1088           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YeungOnion YeungOnion deleted the feat/multivariate-dimension-generic branch September 13, 2024 13:38
@YeungOnion YeungOnion added this to the 0.18 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant