Make rand optional #275
Merged
Make rand optional #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #275 +/- ##
==========================================
+ Coverage 93.54% 93.70% +0.16%
==========================================
Files 53 53
Lines 11657 11636 -21
==========================================
Hits 10904 10904
+ Misses 753 732 -21 ☔ View full report in Codecov by Sentry. |
YeungOnion
reviewed
Sep 5, 2024
YeungOnion
reviewed
Sep 5, 2024
|
Thanks again for what you've put in with the last 24 hours. It looks good, just gotta handle the merge. |
FreezyLemon
force-pushed
the
experiment-make-rand-optional
branch
2 times, most recently
from
161662d to
5ae4760
Compare
|
This should be good to go. I resolved the merge conflicts manually, and the CI failure is just codecov |
YeungOnion
approved these changes
Sep 9, 2024
This changes the behavior of Cauchy::mean() and Cauchy::variance() from the old default implementation (based on RNG sampling) to simply returning `None`. Both mean and variance are undefined for the cauchy distribution. This also changes the trait signature of both Distribution<T> and DiscreteDistribution<T> to not be subtraits of rand::distribution::Distribution<T>. Our distributions do still implement this trait iff the `rand` feature is enabled.
FreezyLemon
force-pushed
the
experiment-make-rand-optional
branch
from
5ae4760 to
35c5dd0
Compare
|
Needed to rebase again after the other PRs were merged. |
|
coverage CI looks stuck. I'm messing around with it on poorly named pr #279 |
|
Now, I will merge the correct thing. Whoops. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #270, making
randoptional means that it's possible to use a very stripped-down version of the crate:Like the
nalgebrafeature,randis enabled by default. This added modularity might make #165 easier, too.This requires a breaking change: Removing the
rand::distribution::Distribution<T>supertrait fromstatrs::distribution::Distribution<T>and::DiscreteDistribution<T>. Semantically, it means that thestatrsdistributions are not required to beranddistributions and are not logical extensions of them. Practically, it just means that new distributions don't necessarily have to implement therandDistribution trait (all current distributions still do implement it with the feature enabled).I would argue that the distribution traits still make sense without rand/RNG. This also allows using most of the
statisticsmodule without needing to compilerandand all that entails.