Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use exp_m1 instead of subtracting directly #294

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

soumyasen1809
Copy link
Contributor

  • Added fix to use exp_m1 function to compute sf for Gumbel distribution more accurately

- Added fix to use exp_m1 function to compute
sf for Gumbel distribution more accurately
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.03%. Comparing base (a395dd1) to head (dccddfd).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #294   +/-   ##
=======================================
  Coverage   94.03%   94.03%           
=======================================
  Files          53       53           
  Lines       12053    12055    +2     
=======================================
+ Hits        11334    11336    +2     
  Misses        719      719           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YeungOnion
Copy link
Contributor

figured I'd also add tests to make this a notable difference. These two tests fail the previous implementation and pass this one.

@YeungOnion YeungOnion merged commit 8e78b2c into statrs-dev:master Sep 17, 2024
11 checks passed
@soumyasen1809 soumyasen1809 deleted the gumbel_issue_cleanup branch September 17, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants