refactor!: forbid α=inf || β=inf in Beta distr. #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes `skewness()` returning an incorrect value for numeric limits and simplifies some functions. Also clarifies and fixes up some docs.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #299 +/- ##
==========================================
- Coverage 93.76% 93.73% -0.03%
==========================================
Files 53 53
Lines 12088 12010 -78
==========================================
- Hits 11334 11258 -76
+ Misses 754 752 -2 ☔ View full report in Codecov by Sentry. |
|
Looks great, would support removing parameters that yield degenerate distributions for other constructors as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
newonly rejects both shapes being infinite. Now, it rejects any of the shapes being infinite.There's been some discussion (#102) about supporting degenerate parameters for distributions. For
Betaspecifically, almost every function (cdf, sf, pdf, mode, mean, ...) needs one or two special cases for infinite parameters, which doesn't seem sensible. For users needing a shape=+/-INF, it makes more sense to create their own struct and then implement the relevant statrs traits, performance- and complexity-wise.This fixes
skewness()returning an incorrect value for numeric limits (#136) and simplifies mostBetafunctions.Also clarifies and fixes up some docs. Breaking because it removes an enum variant from
BetaError, which is public.