Client pass meaningful error to newFut when processMessage failed

status-im · Jan 23, 2024 · dad0255 · dad0255
1 parent 26a6cb1
commit dad0255
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/json_rpc/clients/httpclient.nim b/json_rpc/clients/httpclient.nim
@@ -152,10 +152,11 @@ method call*(client: RpcHttpClient, name: string,
   if msgRes.isErr:
     # Need to clean up in case the answer was invalid
     debug "Failed to process POST Response for JSON-RPC", msg = msgRes.error
-    newFut.cancelSoon()
+    let exc = newException(JsonRpcError, msgRes.error)
+    newFut.fail(exc)
     client.awaiting.del(id)
     closeRefs()
-    raise newException(JsonRpcError, msgRes.error)
+    raise exc
 
   client.awaiting.del(id)
 

diff --git a/json_rpc/servers/websocketserver.nim b/json_rpc/servers/websocketserver.nim
@@ -86,7 +86,7 @@ proc handleRequest(rpc: RpcWebSocketServer, request: HttpRequest) {.async: (rais
           debug "Internal error, while processing RPC call",
             address = $request.uri
           await ws.close(
-            reason = "Internal error, while processing RPC call"
+            reason = "Internal error, while processing RPC call: " & exc.msg
           )
           break