Router.register should not raise exception

status-im · Jan 13, 2024 · f90e946 · f90e946
1 parent 6620805
commit f90e946
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/json_rpc/router.nim b/json_rpc/router.nim
@@ -110,9 +110,12 @@ proc wrapError(code: int, msg: string): string =
 
 proc init*(T: type RpcRouter): T = discard
 
-proc register*(router: var RpcRouter, path: string, call: RpcProc)
-                {.gcsafe, raises: [CatchableError].} =
-  router.procs[path] = call
+proc register*(router: var RpcRouter, path: string, call: RpcProc) =
+  # this proc should not raise exception
+  try:
+    router.procs[path] = call
+  except CatchableError as exc:
+    doAssert(false, exc.msg)
 
 proc clear*(router: var RpcRouter) =
   router.procs.clear