Add Yamux experimental support #5080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe mark this hidden, and/or otherwise signal that it's not a supported option? This seems ideally ephemeral/temporary and to be removed at some point. |
|
Thanks, I wasn't aware that this was possible |
arnetheduck
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mplex is starting to get slowly kicked out of libp2p, and it's probably for the best
We've had experimental yamux in nim-libp2p for a while, but it had limited testing on actual networks
Adding this flag, so that we can test on a few fleet nodes, and in some future, make it default to true
Also see libp2p/specs#553