feat(Onboarding): Create Profile & Login flows #16722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (590)
|
caybro
force-pushed
the
feat/onboarding-rework-1
branch
26 times, most recently
from
fe0f177 to
315bbc0
Compare
caybro
force-pushed
the
feat/onboarding-rework-1
branch
2 times, most recently
from
ad67a76 to
35e9ad5
Compare
jrainville
reviewed
Jan 6, 2025
ui/StatusQ/src/StatusQ/Controls/StatusPasswordStrengthIndicator.qml
Outdated
Show resolved
Hide resolved
ui/StatusQ/src/StatusQ/Controls/StatusPasswordStrengthIndicator.qml
Outdated
Show resolved
Hide resolved
| @@ -75,6 +74,11 @@ Item { | |||
| input text. | |||
| */ | |||
| property ListModel filteredList: ListModel { } | |||
|
|
|||
| property bool isError | |||
There was a problem hiding this comment.
Should this be hasErrror instead?
There was a problem hiding this comment.
Yeah maybe, just followed what we have elsewhere 🤷
| } | ||
| StatusBaseText { | ||
| Layout.fillWidth: true | ||
| text: qsTr("You will require your Keycard to log in to Status and sign transactions") |
There was a problem hiding this comment.
This sentence sounds a bit weird. I'm not sure what we're trying to tell the user
There was a problem hiding this comment.
Not sure either, pre-existing code 🤷
| ListItemButton { | ||
| objectName: "btnBySyncing" | ||
| Layout.fillWidth: true | ||
| text: qsTr("Log in by syncing") // FIXME wording, "Log in by pairing"? |
There was a problem hiding this comment.
Did we confirm if we want Pairing instead? cc @benjthayer
I personally like it better
There was a problem hiding this comment.
Yeah, not sure now; I added a FIXME there, this needs a systemic approach
| @@ -187,7 +187,7 @@ SettingsContentBase { | |||
| anchors.left: parent.right | |||
| anchors.leftMargin: 8 | |||
| anchors.verticalCenter: parent.verticalCenter | |||
| tooltipText: qsTr("Connection problems can happen.<br>If they do, please use the Enter a Seed Phrase feature instead.") | |||
| tooltipText: qsTr("Connection problems can happen.<br>If they do, please use the Enter a Recovery Phrase feature instead.") | |||
There was a problem hiding this comment.
Everywhere else, we don,t capitalize. I assume the old copy was just a mistake
jrainville
force-pushed
the
feat/onboarding-rework-1
branch
from
e505b50 to
adb3474
Compare
micieslak
approved these changes
Jan 7, 2025
caybro
force-pushed
the
feat/onboarding-rework-1
branch
from
45b7c0c to
5a6613a
Compare
- implement the basic Onboarding UI skeleton and the Create Profile flows - adjust the PasswordView and EnterSeedPhrase views to the latest design - add the main OnboardingLayout and StatusPinInput pages to Storybook - change terminology app-wide: "Seed phrase" -> "Recovery phrase" - implement the Login flows (seed, sync, keycard) - amend the keycard flow sequences with separate (non) empty page Fixes #16719 Fixes #16742 Fixes #16743
- extend the tests to verify whether we collected the correct data - restore the "pointing hand" cursor on clickable elements - some minor improvements
- instead of the factory reset when the keycard is locked
- they are not very useful (and were outdated anyway)
micieslak
force-pushed
the
feat/onboarding-rework-1
branch
from
5a6613a to
80f4bca
Compare
4 tasks
micieslak
force-pushed
the
feat/onboarding-rework-1
branch
from
a6d3044 to
d5524fd
Compare
micieslak
force-pushed
the
feat/onboarding-rework-1
branch
from
d5524fd to
35b8620
Compare
|
i will check what is happening with tests |
|
okay i can reproduce the problem. There is a performance degradation it seems) - clicking |
|
@caybro i fixed the tests in PR to let them pass, however lets wait to merge this PR , i am running all tests i have to catch any other changes in another tests that are not running in PRs |
anastasiyaig
force-pushed
the
feat/onboarding-rework-1
branch
from
29ce4b0 to
43a5b68
Compare
|
i fixed everything i wanted @caybro |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Create profile UI flows:
Fixes #16719
Fixes #16742
Fixes #16743
Login UI flows:
Fixes #16798
Fixes #16799
Fixes #16800
Fixes #16977
Affected areas
Onboarding
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)