Feat/request payment cards 16737 #16740
Open
+388
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cuteivist
requested review from
micieslak,
caybro,
alexjba and
a team
as code owners
Jenkins BuildsClick to see older builds (28)
|
Cuteivist
force-pushed
the
feat/request-payment-cards-16737
branch
2 times, most recently
from
7b82665
to
87b9b3e
Compare
caybro
reviewed
Nov 13, 2024
ui/imports/shared/controls/chat/RequestPaymentMiniCardDelegate.qml
Outdated
Show resolved
Hide resolved
alexjba
reviewed
Nov 19, 2024
micieslak
reviewed
Nov 19, 2024
| @@ -41,6 +47,8 @@ Control { | |||
| signal linkReload(string link) | |||
| signal linkClicked(string link) | |||
|
|
|||
| signal paymentRequestRemoved(int index) | |||
There was a problem hiding this comment.
The name suggests that the action has been performed and the signal is called to inform about that executed action. If the signal is called with intention that the user will do the job it should follow the convention with Requested on the end, e.g.:
signal removePaymentRequestRequested(int index)
I know, we have strange naming coincidence here but imo it's ok. Or alternatively removePaymentRequested 🤔
There was a problem hiding this comment.
I'm not sure about Requested part, but to make sure it's clear what is removed I renamed it to: removePaymentRequestPreviewRequested. Made it pretty long though :(
Cuteivist
force-pushed
the
feat/request-payment-cards-16737
branch
from
87b9b3e
to
d1ccce5
Compare
Cuteivist
force-pushed
the
feat/request-payment-cards-16737
branch
from
1b6059d
to
9c3914a
Compare
|
Logic is refactored according to remarks. Please review again @alexjba @caybro @micieslak Thanks |
caybro
reviewed
Nov 27, 2024
|
|
||
| signal imageRemoved(int index) | ||
| signal imageClicked(var chatImage) | ||
| signal linkReload(string link) | ||
| signal linkClicked(string link) | ||
|
|
||
| signal removePaymentRequestPreviewRequested(int index) |
| color: Theme.palette.baseColor1 | ||
| verticalAlignment: Text.AlignVCenter | ||
| elide: Text.ElideRight | ||
| text: root.amount |
| QtObject { | ||
| id: d | ||
| property real bannerImageMargins: 1 / Screen.devicePixelRatio // image size isn't pixel perfect.. | ||
| property bool highlight: root.highlight || root.hovered |
| StatusBaseText { | ||
| Layout.fillWidth: true | ||
| wrapMode: Text.WrapAtWordBoundaryOrAnywhere | ||
| text: qsTr("Send %1 %2 to %3").arg(root.amount).arg(root.symbol).arg(Utils.compactAddress(root.address.toLowerCase(), 4)) |
| const receiver = StatusQUtils.ModelUtils.get(paymentRequestModel, index, "receiver") | ||
| const amount = StatusQUtils.ModelUtils.get(paymentRequestModel, index, "amount") | ||
| const symbol = StatusQUtils.ModelUtils.get(paymentRequestModel, index, "symbol") | ||
| const chainId = StatusQUtils.ModelUtils.get(paymentRequestModel, index, "chainId") |
There was a problem hiding this comment.
You could get the whole row at once, and then get the props
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16737
What does the PR do
Affected areas
Chat
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)