feat: payment request nim input area model #16822
Open
+231
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cuteivist
requested review from
alaibe,
alexjba,
Khushboo-dev-cpp and
saledjenic
Jenkins Builds
|
Cuteivist
force-pushed
the
feat/payment-request-send-message-16739
branch
from
c1a62d1
to
7bdaee9
Compare
alexjba
approved these changes
Nov 27, 2024
| proc getPaymentRequests*(self: Model): seq[PaymentRequest] = | ||
| return self.items | ||
|
|
||
| proc countChanged(self: Model) {.signal.} |
There was a problem hiding this comment.
It's better to use the ModelCount attached property instead of the nim count signal.
In qml you can do something like this:
anyModel.ModelCount.count
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16739
What does the PR do
Nim backend for payment requests
Affected areas
Chat / Community Chat
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide