Skip to content

fix_: cache read-only communities to reduce memory pressure #17781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

osmaczko
Copy link
Contributor

@osmaczko osmaczko requested a review from a team as a code owner April 11, 2025 19:49
@osmaczko osmaczko requested review from iurimatias and a team and removed request for a team April 11, 2025 19:49
@osmaczko osmaczko self-assigned this Apr 11, 2025
@osmaczko
Copy link
Contributor Author

@status-im/desktop-qa would you mind testing the critical communities flow when you get a chance? Your help would be greatly appreciated!

@status-im-auto
Copy link
Member

status-im-auto commented Apr 11, 2025

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 4735c3d #1 2025-04-11 19:58:06 ~8 min macos/aarch64 🍎dmg
✔️ 4735c3d #1 2025-04-11 19:59:24 ~9 min tests/nim 📄log
✔️ 4735c3d #1 2025-04-11 20:02:40 ~13 min tests/ui 📄log
✔️ 4735c3d #1 2025-04-11 20:05:16 ~15 min macos/x86_64 🍎dmg
✔️ 4735c3d #1 2025-04-11 20:13:50 ~24 min linux-nix/x86_64 📦tgz
✔️ 4735c3d #1 2025-04-11 20:14:19 ~24 min linux/x86_64 📦tgz
✔️ 4735c3d #1 2025-04-11 20:16:00 ~26 min windows/x86_64 💿exe
✔️ a6f750a #2 2025-04-14 20:35:29 ~8 min macos/aarch64 🍎dmg
✔️ a6f750a #2 2025-04-14 20:37:08 ~9 min tests/nim 📄log
✔️ a6f750a #2 2025-04-14 20:41:28 ~14 min tests/ui 📄log
✔️ a6f750a #2 2025-04-14 20:49:46 ~22 min macos/x86_64 🍎dmg
✔️ a6f750a #2 2025-04-14 20:50:18 ~23 min linux/x86_64 📦tgz
✔️ a6f750a #2 2025-04-14 20:51:09 ~23 min linux-nix/x86_64 📦tgz
✔️ a6f750a #2 2025-04-14 20:54:33 ~27 min windows/x86_64 💿exe

@virginiabalducci
Copy link

Hi @osmaczko

I'm seeing that this issue #17774 is reproducible on this PR but I think it is because the build of this pR may not include the mentioned fix.

Screenshot 2025-04-14 at 5 15 48 PM

In order to better test the critical flows, including the messages, is it possible to update the build of this PR to include the fix of 17774 ? Thanks!

@osmaczko osmaczko force-pushed the fix/community-extensive-memory-allocations branch from 4735c3d to a6f750a Compare April 14, 2025 20:26
@osmaczko
Copy link
Contributor Author

Hi @osmaczko

I'm seeing that this issue #17774 is reproducible on this PR but I think it is because the build of this pR may not include the mentioned fix.

Screenshot 2025-04-14 at 5 15 48 PM

In order to better test the critical flows, including the messages, is it possible to update the build of this PR to include the fix of 17774 ? Thanks!

@virginiabalducci thanks for looking into this. Rebased, build in progress.

@virginiabalducci
Copy link

virginiabalducci commented Apr 15, 2025

Testing is in progress

Issues found so far:

Channel permissions
It seems that when a channel is created and it is added a permission this does not take effect.

Steps:

  1. create a new channel
  2. add a permission to be token restricted (either by collectibles or tokens)
  3. save the changes

Actual result: nothing happens, the permission is not saved. Errors show on the app console
Expected result: the permission to be saved and take effect.

Screen.Recording.2025-04-15.at.12.30.11.PM.mov
Screen.Recording.2025-04-15.at.12.33.22.PM.mov

app_20250414_224452.log

@osmaczko I've tested the channel permissions on today's master, and they work well. Could you check the permissions on the build of this PR? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: QA
Development

Successfully merging this pull request may close these issues.

3 participants