Enable News Feed feature flag #17830
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vacy and notification views - Created new flag into `PrivacyStore`: `isStatusNewsViaRSSEnabled `. It MUST be connected to the corresponding backend property. - Created new property `notificationsSettings` into `NotificationsStore` and replaced the direct call to the `appSettings` backend property from `NotificationsView`. Now it uses the store as a bridge. - Added the needed UI components in `PrivacyAndSecurityView` + `NotificationsView` to configure the needed Status News related settings. TODO: Backend connections not ready here. Part of #17795
It creates a component placeholder for both `Enable RSS Notifications` and `Enable Status News` information panel and integrates it into the AC logic. Closes #17795
Fixes #17811 Hooks the NewsFeedNotification setting and the RSS setting to the backend. The Notification setting has a bit of complexity on the service side, because while the UI setting is a select of 3 options, the status-go settings are actually 2 bool settings. So the service does some logic to set the right setting from those two. The settings are used to disable the polling if one of the settings is disabled. If the setting is on DeliverQuietly, the AC notif is shown, but no notificaiton
Jenkins Builds
|
jrainville
force-pushed
the
chore/news-feed-feature-flag
branch
from
ed6272f to
f239994
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For testing purposes only for now