fix: Default to full screen window on the first run #17836
Conversation
This is especially useful for devices with virtual keyboard. When the app is full screen, the default behavior would be for the keyboard to push the content up when showing so that the text input area isn't covered by the virtual keyboard.
alexjba
requested review from
richard-ramos,
caybro,
micieslak and
noeliaSD
and removed request for
a team and
richard-ramos
Jenkins Builds
|
| @@ -15,7 +15,7 @@ const DEFAULT_SCROLL_VELOCITY = 0 # unset | |||
| const DEFAULT_SCROLL_DECELERATION = 0 # unset | |||
| const LAS_KEY_CUSTOM_MOUSE_SCROLLING_ENABLED = "global/custom_mouse_scroll_enabled" | |||
| const DEFAULT_CUSTOM_MOUSE_SCROLLING_ENABLED = false | |||
| const DEFAULT_VISIBILITY = 2 #windowed visibility, from qml | |||
| const DEFAULT_VISIBILITY = 5 #full screen visibility, from qml | |||
There was a problem hiding this comment.
Almost sure this will result, at least on Linux, in the window not having any decoration at all
There was a problem hiding this comment.
| const DEFAULT_VISIBILITY = 5 #full screen visibility, from qml | |
| const DEFAULT_VISIBILITY = 1 #automatic visibility, from qml |
This should default to either Fullscreen (supposedly on mobile OSs), or to Windowed otherwise; see https://doc.qt.io/qt-6.8/qwindow.html#Visibility-enum
There was a problem hiding this comment.
Similar to what I'm showing in the description?
There was a problem hiding this comment.
That was my first intention. But unfortunately it doesn't work. It's still windowed.
What about defaulting to maximized then? It should still have the window decorations 🤔
There was a problem hiding this comment.
That was my first intention. But unfortunately it doesn't work. It's still windowed.
What about defaulting to maximized then? It should still have the window decorations 🤔
Yeah that's a better idea :) Or you could make the DEFAULT_VISIBILITY conditional based on the runtime OS
There was a problem hiding this comment.
yeah, I think I'll do that. Maximized is not going to work on all configurations and screen sizes.
There was a problem hiding this comment.
Tested on iOS pad and with const DEFAULT_VISIBILITY = 1 I can state that it does not fit the requirement. I agree also in making it conditional and use 5 when necessary.
What does the PR do
Closes #17835
This is especially useful for devices with virtual keyboard. When the app is full screen, the default behavior would be for the keyboard to push the content up when showing so that the text input area isn't covered by the virtual keyboard.
The window size and position is still saved to settings.
Affected areas
Window default size
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)
Untitled.mov