upgrade react-native to 0.75.3 #21268
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (120)
|
siddarthkay
force-pushed
the
upgrade-react-native-to-0-75-x
branch
2 times, most recently
from
169d36e to
9539861
Compare
siddarthkay
force-pushed
the
upgrade-react-native-to-0-75-x
branch
2 times, most recently
from
6a2ebae to
8abe656
Compare
siddarthkay
commented
Sep 18, 2024
| org.junit:junit-bom:5.9.3 | ||
| org.junit:junit-bom:5.9.2 | ||
| org.codehaus.mojo:animal-sniffer-annotations:1.23 | ||
| com.android.tools.lint:lint-gradle:31.5.0' \ |
There was a problem hiding this comment.
note to self : I need to try https://github.com/gradle/github-dependency-graph-gradle-plugin/tree/main#:~:text=Using%20the%20plugin%20to%20generate%20dependency%20reports as suggested by @mendelskiv93
There was a problem hiding this comment.
This shit is tragic and unsustainable...
siddarthkay
commented
Sep 18, 2024
siddarthkay
commented
Sep 18, 2024
siddarthkay
commented
Sep 18, 2024
siddarthkay
commented
Sep 18, 2024
siddarthkay
force-pushed
the
upgrade-react-native-to-0-75-x
branch
from
0dced72 to
96d667e
Compare
siddarthkay
force-pushed
the
use-nixpkgs-unstable-gradle-8-8
branch
from
17180a0 to
9ed6679
Compare
siddarthkay
force-pushed
the
upgrade-react-native-to-0-75-x
branch
from
96d667e to
e469409
Compare
siddarthkay
force-pushed
the
use-nixpkgs-unstable-gradle-8-8
branch
5 times, most recently
from
e64d894 to
3c5b671
Compare
siddarthkay
force-pushed
the
upgrade-react-native-to-0-75-x
branch
from
e469409 to
307b76d
Compare
jakubgs
requested changes
Sep 26, 2024
| org.junit:junit-bom:5.9.3 | ||
| org.junit:junit-bom:5.9.2 | ||
| org.codehaus.mojo:animal-sniffer-annotations:1.23 | ||
| com.android.tools.lint:lint-gradle:31.5.0' \ |
There was a problem hiding this comment.
This shit is tragic and unsustainable...
siddarthkay
force-pushed
the
upgrade-react-native-to-0-75-x
branch
2 times, most recently
from
4a62604 to
0070bfc
Compare
|
it is a big effort and I agree that we should merge it somewhere after release cut (not sure exactly which release are we talking about :) )
|
siddarthkay
force-pushed
the
upgrade-react-native-to-0-75-x
branch
from
6f6c688 to
ac3984a
Compare
siddarthkay
force-pushed
the
upgrade-react-native-to-0-75-x
branch
from
2c01ef3 to
8a5843a
Compare
flexsurfer
approved these changes
Jan 17, 2025
siddarthkay
force-pushed
the
upgrade-react-native-to-0-75-x
branch
from
8a5843a to
dc86a53
Compare
|
@status-im/mobile-qa : PR ready for testing |
ilmotta
approved these changes
Jan 17, 2025
siddarthkay
force-pushed
the
upgrade-react-native-to-0-75-x
branch
2 times, most recently
from
7142492 to
32497fd
Compare
54% of end-end tests have passedFailed tests (25)Click to expandClass TestFallbackMultipleDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePRTwo:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (30)Click to expandClass TestDeepLinksOneDevice:
Class TestFallbackMultipleDevice:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestWalletMultipleDevice:
Class TestWalletOneDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
|
|
@siddarthkay PR_ISSUE 1 (e2e blocker): Element "edit profile picture" missing in XML structureThis issue was detected during E2E testing and is blocking all tests related to updating the profile image. Steps to Reproduce:
Expected Result: Actual Result: Suggested Solution: Environment: |
PR_ISSUE 2: Black stripe sticked to header when Testmode is enabled (Android)Steps:
Expected result (nightly): Actual result (PR): OS: Android, Graphene OS |
PR_ISSUE 3 (e2e blocker): Element "Invite user" is missing in XML structureThis issue was detected during E2E testing and is blocking all tests related to inviting users to communities. Steps:
Expected result: Actual result: screencast.2025-01-20.17-18-41.mp4OS: Android |
PR_ISSUE 4: Buttons are misaligned and have inconsistent sizes in the bottom sheetThe issue applies to any bottom sheet component; the provided case is just one example. Steps to Reproduce:
Expected Result:Buttons are aligned consistently and have equal sizes for a uniform UI experience.
Actual Result:Buttons are misaligned and have different sizes, leading to a disjointed appearance.
Environment:
|
PR_ISSUE 5: Elements are overlapped on AndroidSteps:
Expected result: Actual result: OS: Android, Graphene OS |
PR_ISSUE 6: Confirmation dialog options are invisibleSteps:
Expected result: Actual result: OS: Android, Graphene OS |
|
I updated description with found issues, for now we need a decision what we should fix in the scope of PR (from my perspective we should fix all of the issues, regression is quite extensive) cc @ilmotta |
I agree with @churik (and btw great work finding all those problems), regressions are significant. The |
|
For the missing elements in the XML structure, the reason might be React Native now is collapsing more views than before as an optimization technique. We could try fixing it by adding the prop |
|
I'm going to try to solve the missing elements by specifying a test-id first. That would seem better in theory compared to messing with react-native's view flattening optimisation. |
jakubgs
approved these changes
Jan 24, 2025
| # Generate initial autolinking.json using react-native config | ||
| echo "Generating autolinking.json..." | ||
| ${pkgs.nodejs}/bin/node \ | ||
| ${deps.nodejs-patched}/node_modules/react-native/cli.js config > ${autolinkingPath}/autolinking.json |
There was a problem hiding this comment.
Is this something that has to run with application code checked out, or could this be done as part of deps.nodejs-patched?
There was a problem hiding this comment.
If this doesn't make sense and would just complicate things more than they are right now I guess it's fine as it is.
There was a problem hiding this comment.
I tested and found out that react-native config does indeed need application code and won't generate a config with just node_modules
Its simpler now to just keep this as part of android derivation, else we'd have to check out application code in nodejs-patched derivation.
siddarthkay
force-pushed
the
upgrade-react-native-to-0-75-x
branch
from
32497fd to
662e18f
Compare
This commit upgrades `react-native` to `v0.75.3` Following changes were also made : - `NDK` upgraded to `26.1.10909125` - `@react-native/gradle-plugin` is set up using `includeBuild` gradle mechanism which is a better way. - `reactjs` is upgraded to `18.3.1` - `react-native-config` is upgraded to `1.5.3` - `react-native-navigation` is upgraded to `7.40.1` - `react-native-reanimated` is upgraded to `3.16.6` - `react-native-gesture-handler` is upgraded to `2.22.0` - `react-native-keychain` is upgraded to `9.2.2` - patches for react-native-navigation are updated. PR in RNN repo -> wix/react-native-navigation#7913 - patched autolinking behaviour in `react-native` to prevent generating `autolinking.json` in a gradle step. We run gradle in a sandbox with `--offline` so this is not feasible for us. We do the same thing via a nix phase called `autolinkPhase`. - `AGP` is bumped to `8.5.0` and `aapt2` is bumped to `8.5.0-11315950` - we no longer need to patch out `-X` from `script_phases-patched.sh` - `gradle` deps were updated. - `pods` were updated. - `gems` were updated.
siddarthkay
force-pushed
the
upgrade-react-native-to-0-75-x
branch
from
662e18f to
f677ebb
Compare
The issues related to black areas in the screen or this one (number 5) are due to issues with
need the hole-view because they are transparent, do we really need that transparency? opaque cards would fix the issue. However, I understand a fix isn't possible everywhere (or is it?). Here's a link to the issue in the hole-view repo, they say they aren't going to fix it yet: I believe this wil be a blocker for us, some alternatives are:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades
react-nativetov0.75.3Following changes were also made :
NDKupgraded to26.1.10909125@react-native/gradle-pluginis set up usingincludeBuildgradle mechanism which is a better way.reactjsis upgraded to18.3.1react-native-configis upgraded to1.5.3react-native-navigationis upgraded to7.40.1react-native-reanimatedis upgraded to3.16.6react-native-gesture-handleris upgraded to2.22.0react-native-keychainis upgraded to9.2.2react-nativeto prevent generatingautolinking.jsonin a gradle step. We run gradle in a sandbox with--offlineso this is not feasible for us.We do the same thing via a nix phase called
autolinkPhase.AGPis bumped to8.5.0andaapt2is bumped to8.5.0-11315950-Xfromscript_phases-patched.shgradledeps were updated.podswere updated.gemswere updated.Testing notes
Intense testing is required.
Platforms
Side Effects
status: ready
Found Issues
PR_ISSUE 1 (e2e blocker): Element "edit profile picture" missing in XML structure
Notes:
PR_ISSUE 2: Black stripe sticked to header when Testmode is enabled (Android)
Notes:
PR_ISSUE 3 (e2e blocker): Element "Invite user" is missing in XML structure
Notes:
PR_ISSUE 4: Buttons are misaligned and have inconsistent sizes in the bottom sheet
Notes:
PR_ISSUE 5: Elements are overlapped on Android
Notes:
PR_ISSUE 6: Confirmation dialog options are invisible
Notes: