Updated unit test and documentation

stdevel · Jun 29, 2018 · fa088bc · fa088bc
1 parent 02f646d
commit fa088bc
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 3 deletions.
diff --git a/doc/manpages/src/katprep_maintenance.1.md b/doc/manpages/src/katprep_maintenance.1.md
@@ -134,6 +134,9 @@ This utility supports the following commands
 - **verify** - Verifying status (checking snapshots and downtime)
 - **cleanup** - Cleaning-up (removing downtimes and snapshots)
 
+**IMPORTANT NOTE**:
+For rebooting VMs after system maintenance, at least Foreman 1.15.x or Red Hat Satellite 6.3 is required.
+
 FILES
 =====
 

diff --git a/doc/source/examples.rst b/doc/source/examples.rst
@@ -118,6 +118,8 @@ Several errata will be installed on the systems. Now, go ahead and omit the simu
 
   $ katprep_maintenance -C mycontainer.auth -S foreman.localdomain.loc errata-snapshot-*.json -r execute
 
+.. note:: For rebooting VMs after system maintenance, at least Foreman 1.15.x or Red Hat Satellite 6.3 is required.
+
 Once the systems have been patched (*and maybe also rebooted*), it's time to check whether the monitoring status is fine, again::
 
   $ katprep_maintenance -C mycontainer.auth -S foreman.localdomian.loc errata-snapshot-*.json verify

diff --git a/doc/source/man/katprep_maintenance.1.rst b/doc/source/man/katprep_maintenance.1.rst
@@ -133,6 +133,9 @@ This utility supports the following commands
 -  **verify** - Verifying status (checking snapshots and downtime)
 -  **cleanup** - Cleaning-up (removing downtimes and snapshots)
 
+**IMPORTANT NOTE**: For rebooting VMs after system maintenance, at least
+Foreman 1.15.x or Red Hat Satellite 6.3 is required.
+
 FILES
 =====
 

diff --git a/tests/PyvmomiClientTest.py b/tests/PyvmomiClientTest.py
@@ -86,8 +86,16 @@ def test_valid_login(self):
         Ensure exceptions on valid logins
         """
         #dummy call
-        #TODO: other call?
-        self.pyvmomi_client.get_vm_ips()
+        try:
+            result = self.pyvmomi_client.has_snapshot(
+                self.config["valid_objects"]["vm"],
+                self.dummy_snapshot
+            )
+            self.assertTrue(
+                result in [True, False]
+            )
+        except EmptySetException:
+            pass
 
     def test_invalid_login(self):
         """
@@ -99,7 +107,6 @@ def test_invalid_login(self):
                 "giertz", "paulapinkepank"
             )
             #dummy call
-            #TODO. other call?
             api_dummy.get_vm_ips()