Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix Address commit comments (commit ad7a023) #5901 #5945

Closed
wants to merge 4 commits into from

Conversation

Kaushikgtm
Copy link
Contributor

@Kaushikgtm Kaushikgtm commented Mar 10, 2025

Resolves #5901 .

Description

What is the purpose of this pull request?

This pull request:

  • {{TODO: add description describing what this pull request does}}

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves #{{TODO: add issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Signed-off-by: Kaushikgtm <[email protected]>
Signed-off-by: Kaushikgtm <[email protected]>
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Mar 10, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Mar 10, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 10, 2025

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/levy/variance $\color{green}176/176$
$\color{green}+100.00\%$
$\color{green}9/9$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}176/176$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Kaushikgtm
Copy link
Contributor Author

@Planeshifter review this PR

@stdlib-bot stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Mar 11, 2025
@Kaushikgtm
Copy link
Contributor Author

Hii @Planeshifter please review my pr and suggest changes if any

@Kaushikgtm
Copy link
Contributor Author

Hii @kgryte review my pr

Copy link
Contributor

@hrshya hrshya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order for this PR to be merged, all lint errors need to be addressed. You need to replace the PR title as well to chore : address commit comments and update the PR description and related issue section as well and your implementation is wrong in the commit so update it as well here is an example : replace ( randu() * 10.0 + EPS ) with uniform( EPS, 10.0 )

@Kaushikgtm Kaushikgtm changed the title Address commit comments (commit ad7a023) #5901 chore: fix Address commit comments (commit ad7a023) #5901 Mar 17, 2025
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 17, 2025
Signed-off-by: Kaushikgtm <[email protected]>
Signed-off-by: Kaushikgtm <[email protected]>
@Kaushikgtm Kaushikgtm closed this Mar 29, 2025
@Kaushikgtm Kaushikgtm deleted the Kaushikgtm-patch-20 branch March 29, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First PR A pull request resolving a Good First Issue. Needs Changes Pull request which needs changes before being merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address commit comments (commit ad7a023)
4 participants