Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 5895 #5975

Closed
wants to merge 6 commits into from
Closed

Fix issue 5895 #5975

wants to merge 6 commits into from

Conversation

akash8843
Copy link

Resolves #5895

Description

What is the purpose of this pull request?

This pull request fixes comments related to the benchmark issue and functionality for better code clarity and documentation.

Related Issues

Does this pull request have any related issues?

This pull request:
Resolves #5895

Acknowledgment

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request?
This may include screenshots, references, and/or implementation notes.

No.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 11, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 11, 2025

Coverage Report

Package Statements Branches Functions Lines
math/base/special/binet $\color{green}250/250$
$\color{green}+100.00\%$
$\color{green}9/9$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}250/250$
$\color{green}+100.00\%$
stats/base/dists/levy/variance $\color{green}176/176$
$\color{green}+100.00\%$
$\color{green}9/9$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}176/176$
$\color{green}+100.00\%$
stats/base/dists/normal/mgf $\color{green}293/293$
$\color{green}+100.00\%$
$\color{green}19/19$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}293/293$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@akash8843
Copy link
Author

Subject: Request for Code Review — Fix for Issue #5895

Hello @stdlib-bot ,@kgryte ,

I have worked on resolving issue #5895 and have submitted a pull request for the changes. I have made the necessary fixes, updated the comments, and ensured that the code aligns with the project's guidelines.

Could you please review my pull request whenever you have time? Let me know if there are any improvements or adjustments needed.

Thank you for your guidance and support!

Best regards,
Akash Shukla

@Planeshifter Planeshifter added the Potential Duplicate There might be another pull request resolving the same issue. label Mar 15, 2025
@kgryte
Copy link
Member

kgryte commented Mar 17, 2025

@akash8843 Thank you for your interest in stdlib; however, same comments as #5954. Namely, this PR includes many undesired changes and the referenced issue was already addressed in #5953. As such, I am going to close this PR.

@kgryte kgryte closed this Mar 17, 2025
@kgryte kgryte added Invalid Invalid question, issue, or pull request. and removed Needs Review A pull request which needs code review. Potential Duplicate There might be another pull request resolving the same issue. labels Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Invalid Invalid question, issue, or pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address commit comments (commit aec0e88)
4 participants