Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: address commit comments #6011

Merged
merged 1 commit into from
Mar 13, 2025
Merged

Conversation

thedeeppp
Copy link
Contributor

Resolves #6002 .

Description

What is the purpose of this pull request?

This pull request:

  • {{TODO: add description describing what this pull request does}}

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

  • there's mentioned about line 50 (i.e. 3rd task) but it looks fine to me
    {492A06E0-2C8A-41BB-9CAA-052DED1C7BCB}
    Isn't this what was expected?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 13, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dnanstdevwd $\color{green}350/350$
$\color{green}+100.00\%$
$\color{green}13/13$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}350/350$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Planeshifter Planeshifter changed the title fixed as per comments chore: address commit comments Mar 13, 2025
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Mar 13, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 13, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

chore: address commit comments

PR-URL: https://github.com/stdlib-js/stdlib/pull/6011
Closes: https://github.com/stdlib-js/stdlib/issues/6002

Co-authored-by: the_deeppp <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@stdlib-bot stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Mar 13, 2025
@Planeshifter Planeshifter merged commit dc9f39f into stdlib-js:develop Mar 13, 2025
98 of 99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address commit comments (commit d8322de)
3 participants