Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix EditorConfig lint error #6039

Closed

Conversation

Shivam-1827
Copy link
Contributor

Resolves #6031

Description

What is the purpose of this pull request?

This pull request:

  • Fixes EditorConfig linting errors by replacing tabs with spaces in affected files.
  • Ensures adherence to the project's .editorconfig rules for indentation.
  • Updates the manifest.json file in lib/node_modules/@stdlib/number/float32/base/exponent/ to use spaces instead of tabs.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

  • Ran make lint-editorconfig-files locally to verify the fix.
  • Ensured no other formatting issues remain in the affected files.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 14, 2025
Copy link
Member

@aayush0325 aayush0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the issue only asks you to fix the editorconfig errors in manifest.json of @stdlib/number/base/float32, why have you made these other changes?

@Shivam-1827
Copy link
Contributor Author

while testing those files were giving errors, i will fix it out.

@kgryte
Copy link
Member

kgryte commented Mar 17, 2025

As this PR contains a number of undesired changes and does not specifically address #6031, I'll go ahead and close.

@kgryte kgryte closed this Mar 17, 2025
@kgryte kgryte added Invalid Invalid question, issue, or pull request. and removed Needs Review A pull request which needs code review. labels Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First PR A pull request resolving a Good First Issue. Invalid Invalid question, issue, or pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix EditorConfig lint errors
4 participants