-
-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add constants/float32/pi-squared
#6069
base: develop
Are you sure you want to change the base?
feat: add constants/float32/pi-squared
#6069
Conversation
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
||
<section class="related"> | ||
|
||
* * * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comments regarding related packages in newly added packages.
lib/node_modules/@stdlib/constants/float32/pi-squared/README.md
Outdated
Show resolved
Hide resolved
I have made these changes for other PR's as well!! sorry for the confusion from my side. |
/** | ||
* Macro for π². | ||
*/ | ||
#define STDLIB_CONSTANT_FLOAT32_PI_SQUARED 9.869604f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sanity check: there are only 6 significant decimal digits for this value in single-precision?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I would do instead is
9.869604401089358f
Meaning take the double-precision value and add an f
suffix. The compiler can then take care of proper rounding in C.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh apparently while hovering over the val VS code gave its own rounded off version for this inside 7-decimal places. But I'll make this change.
Progresses #649
Resolves #6070 .
Description
This pull request:
constants/float32/pi-squared
Related Issues
This pull request:
progresses [RFC]: Add C implementations to base special math functions (tracking issue) #649
resolves [RFC]: add
constants/float32/pi-squared
#6070Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers